Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devcontainer PHP dependencies to 8.3 #45086

Merged
merged 2 commits into from
May 4, 2024
Merged

Update devcontainer PHP dependencies to 8.3 #45086

merged 2 commits into from
May 4, 2024

Conversation

R0Wi
Copy link
Member

@R0Wi R0Wi commented Apr 28, 2024 •
edited
Loading

Summary

  • Updates devcontainer PHP runtime to 8.3
  • Updates the devcontainer base image to ubuntu:noble to be able to use PHP 8.3 natively

TODO

Nothing

Checklist

susnux
susnux reviewed Apr 28, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead switch to Ubuntu noble (24.04) as the image base so no 3rd party ppa are needed for php 8.3

@R0Wi R0Wi force-pushed the update-devcontainer-env#45075 branch from 504f9dc to af8d289 Compare May 2, 2024 18:07
@R0Wi
Copy link
Member Author

R0Wi commented May 2, 2024

There we go 👍 I was also wondering if we should push a prebuilt image (something like nextcloud-devcontainer:latest) to the docker hub. This would speed up the devcontainer bootstrapping quite a bit?

@R0Wi R0Wi requested a review from susnux May 2, 2024 18:09
susnux
susnux reviewed May 2, 2024
View reviewed changes
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@R0Wi @susnux
Update .devcontainer/Dockerfile
85f293c 
Co-authored-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Robin Windey <[email protected]>
@R0Wi R0Wi requested a review from susnux May 2, 2024 20:00
@susnux susnux merged commit fe4c1b2 into master May 4, 2024
103 of 104 checks passed
@susnux susnux deleted the update-devcontainer-env#45075 branch May 4, 2024 13:55
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

@susnux susnux susnux approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update devcontainer PHP environment to PHP 8.3
3 participants
@R0Wi @susnux @bigcat88